svn commit: r187051 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb netgraph

Alexander Motin mav at FreeBSD.org
Sun Jan 11 03:51:19 PST 2009


Author: mav
Date: Sun Jan 11 11:51:18 2009
New Revision: 187051
URL: http://svn.freebsd.org/changeset/base/187051

Log:
  MFC rev. 186907:
  
  Mark ng_vjc node as FORCE_WRITER to protect slcompress state.
  I think it can be the reason of livelock in netgraph reported by some
  mpd users.

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/ath/ath_hal/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)
  stable/7/sys/netgraph/ng_vjc.c

Modified: stable/7/sys/netgraph/ng_vjc.c
==============================================================================
--- stable/7/sys/netgraph/ng_vjc.c	Sun Jan 11 11:36:00 2009	(r187050)
+++ stable/7/sys/netgraph/ng_vjc.c	Sun Jan 11 11:51:18 2009	(r187051)
@@ -249,6 +249,9 @@ ng_vjc_constructor(node_p node)
 
 	NG_NODE_SET_PRIVATE(node, priv);
 
+	/* slcompress is not thread-safe. Protect it's state here. */
+	NG_NODE_FORCE_WRITER(node);
+
 	/* Done */
 	return (0);
 }


More information about the svn-src-stable-7 mailing list