svn commit: r365543 - in stable/12/sys/dev: an wi

Warner Losh imp at FreeBSD.org
Wed Sep 9 23:05:49 UTC 2020


Author: imp
Date: Wed Sep  9 23:05:47 2020
New Revision: 365543
URL: https://svnweb.freebsd.org/changeset/base/365543

Log:
  MFC r365015:
  r365015 | imp | 2020-08-31 17:31:16 -0600 (Mon, 31 Aug 2020) | 12 lines
  
  Warn for the non pccard attachments
  
  These devices have non-pccard attachments. Warn for those as well. Both an and
  wi don't do the modern cyrpto needed to use these cards on secure wifi networks.
  an needs firmware from Cisco, which I don't think was ever produced. wi could
  in theory do it with raw frames and on-host encryption, but nobody has written
  that in the 15 years since WEP was cracked.
  
  MFC After: 3 days
  Noticed by: rgrimes
  Differential Revision: https://reviews.freebsd.org/D26138

Modified:
  stable/12/sys/dev/an/if_an_isa.c
  stable/12/sys/dev/an/if_an_pccard.c
  stable/12/sys/dev/an/if_an_pci.c
  stable/12/sys/dev/wi/if_wi_macio.c
  stable/12/sys/dev/wi/if_wi_pccard.c
  stable/12/sys/dev/wi/if_wi_pci.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/an/if_an_isa.c
==============================================================================
--- stable/12/sys/dev/an/if_an_isa.c	Wed Sep  9 23:04:40 2020	(r365542)
+++ stable/12/sys/dev/an/if_an_isa.c	Wed Sep  9 23:05:47 2020	(r365543)
@@ -127,6 +127,7 @@ an_attach_isa(device_t dev)
 		an_release_resources(dev);
 		return (error);
 	}
+	gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto");
 	return (0);
 }
 

Modified: stable/12/sys/dev/an/if_an_pccard.c
==============================================================================
--- stable/12/sys/dev/an/if_an_pccard.c	Wed Sep  9 23:04:40 2020	(r365542)
+++ stable/12/sys/dev/an/if_an_pccard.c	Wed Sep  9 23:05:47 2020	(r365543)
@@ -157,6 +157,6 @@ fail:
 	if (error)
 		an_release_resources(dev);
 	else
-		gone_in_dev(dev, 13, "pccard removed");
+		gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto");
 	return (error);
 }

Modified: stable/12/sys/dev/an/if_an_pci.c
==============================================================================
--- stable/12/sys/dev/an/if_an_pci.c	Wed Sep  9 23:04:40 2020	(r365542)
+++ stable/12/sys/dev/an/if_an_pci.c	Wed Sep  9 23:05:47 2020	(r365543)
@@ -230,7 +230,8 @@ an_attach_pci(dev)
 	    NULL, an_intr, sc, &sc->irq_handle);
 	if (error)
 		device_printf(dev, "couldn't setup interrupt\n");
-
+	else
+		gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto");
 fail:
 	if (error)
 		an_release_resources(dev);

Modified: stable/12/sys/dev/wi/if_wi_macio.c
==============================================================================
--- stable/12/sys/dev/wi/if_wi_macio.c	Wed Sep  9 23:04:40 2020	(r365542)
+++ stable/12/sys/dev/wi/if_wi_macio.c	Wed Sep  9 23:05:47 2020	(r365543)
@@ -142,6 +142,8 @@ wi_macio_attach(device_t dev)
 		error = wi_attach(dev);
 		if (error != 0)
 			wi_free(dev);
+		else
+			gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto");
 	}
 	return error;
 }

Modified: stable/12/sys/dev/wi/if_wi_pccard.c
==============================================================================
--- stable/12/sys/dev/wi/if_wi_pccard.c	Wed Sep  9 23:04:40 2020	(r365542)
+++ stable/12/sys/dev/wi/if_wi_pccard.c	Wed Sep  9 23:05:47 2020	(r365543)
@@ -200,7 +200,7 @@ wi_pccard_attach(device_t dev)
 		error = wi_attach(dev);
 		if (error != 0)
 			wi_free(dev);
-		gone_in_dev(dev, 13, "pccard removed");
+		gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto");
 	}
 	return error;
 }

Modified: stable/12/sys/dev/wi/if_wi_pci.c
==============================================================================
--- stable/12/sys/dev/wi/if_wi_pci.c	Wed Sep  9 23:04:40 2020	(r365542)
+++ stable/12/sys/dev/wi/if_wi_pci.c	Wed Sep  9 23:05:47 2020	(r365543)
@@ -233,6 +233,8 @@ wi_pci_attach(device_t dev)
 	error = wi_attach(dev);
 	if (error != 0)
 		wi_free(dev);
+	else
+		gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto");
 	return (error);
 }
 


More information about the svn-src-stable-12 mailing list