svn commit: r347951 - stable/12/lib/libc/stdlib

[Konstantin Belousov]

On Sat, May 18, 2019 at 08:39:03AM -0400, Benedict Reuschling wrote:
> Hello Konstantin and Bruce,
> 
> thank you for your comments. Clearly, this should have been addressed in
> the review and checked by a second pair of eyes. I mostly did the man
> page changes and can't comment much on the actual coding example. Two
> people (dab and jilles) approved the revision in the Phabricator review.
> There was plenty of time to review it between April 16 and May 15 when
> then the original submitter asked if there was anything else that needs
> to be done.
> 
> Now, having said that and the the change is now both in HEAD and
> stable/12, how do we proceed? Revert them both or patch those issues as
> follow-ups? Note that a src committer should do that and not me trying
> to add more EXAMPLE sections to man pages with my doc commit bit.
> 

Try to improve it.  I think there is some value in having a good
and non-buggy example for the function(s), but we are not there yet.
You have a lot of comments with direct actions.