svn commit: r313632 - in stable/10/contrib/netbsd-tests/lib/libc/gen: . posix_spawn

Ed Schouten ed at nuxi.nl
Sat Feb 11 09:12:39 UTC 2017


2017-02-11 8:35 GMT+01:00 Ngie Cooper <ngie at freebsd.org>:
>   Note that sys/types.h is required on FreeBSD for kqueue(2), unlike NetBSD

Which is a bug on its own in my opinion. What do you think of this patch?

Index: sys/sys/event.h
===================================================================
--- sys/sys/event.h (revision 313335)
+++ sys/sys/event.h (working copy)
@@ -29,7 +29,8 @@
 #ifndef _SYS_EVENT_H_
 #define _SYS_EVENT_H_

-#include <sys/queue.h>
+#include <sys/_types.h>
+#include <sys/queue.h>

 #define EVFILT_READ (-1)
 #define EVFILT_WRITE (-2)
@@ -57,11 +58,11 @@
 } while(0)

 struct kevent {
- uintptr_t ident; /* identifier for this event */
+ __uintptr_t ident; /* identifier for this event */
  short filter; /* filter for event */
- u_short flags;
- u_int fflags;
- intptr_t data;
+ unsigned short flags;
+ unsigned int fflags;
+ __intptr_t data;
  void *udata; /* opaque user data identifier */
 };


-- 
Ed Schouten <ed at nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717


More information about the svn-src-stable-10 mailing list