svn commit: r272372 - stable/10/bin/rm

[NGie Cooper]

On Wed, Oct 1, 2014 at 11:16 PM, Glen Barber <gjb at freebsd.org> wrote:
> On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote:
>> On Wed, 1 Oct 2014, Glen Barber wrote:
>>
>> >Log:
>> > MFC r268376 (imp):
>> >
>> >   rm -rf can fail sometimes with an error from fts_read. Make it
>> >   honor fflag to ignore fts_read errors, but stop deleting from
>> >   that directory because no further progress can be made.
>>
>> I asked for this to be backed out in -current.  It is not suitable for MFC.
>>
>
> It fixes an immediate issue that prevents high-concurrent make(1) jobs
> from stomping over each other.

The real problem is noted in this bug:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 ; the
SUBDIR_PARALLEL logic is executing multiple instances of the
clean/cleandir .PHONY targets.

I agree with bde@ that this commit is papering over a bigger problem,
but it's annoying enough and causes enough false positives that I
understand why gjb@ MFCed the commit imp@ did in head.

Thank you..