svn commit: r209354 - projects/ppc64/sys/powerpc/aim

Nathan Whitehorn nwhitehorn at FreeBSD.org
Sat Jun 19 20:34:37 UTC 2010


Author: nwhitehorn
Date: Sat Jun 19 20:34:37 2010
New Revision: 209354
URL: http://svn.freebsd.org/changeset/base/209354

Log:
  Change a silent failure to a loud failure.

Modified:
  projects/ppc64/sys/powerpc/aim/mmu_oea64.c

Modified: projects/ppc64/sys/powerpc/aim/mmu_oea64.c
==============================================================================
--- projects/ppc64/sys/powerpc/aim/mmu_oea64.c	Sat Jun 19 20:11:06 2010	(r209353)
+++ projects/ppc64/sys/powerpc/aim/mmu_oea64.c	Sat Jun 19 20:34:37 2010	(r209354)
@@ -2814,8 +2814,8 @@ moea64_pte_insert(u_int ptegidx, struct 
 
 	LIST_FOREACH(pvo, &moea64_pvo_table[pteg_bktidx], pvo_olink) {
 		if (pvo->pvo_pte.lpte.pte_hi == pt->pte_hi) {
-			if (!(pvo->pvo_pte.lpte.pte_hi & LPTE_VALID))
-				continue;
+			KASSERT(pvo->pvo_pte.lpte.pte_hi & LPTE_VALID, 
+			    ("Invalid PVO for valid PTE!\n"));
 			moea64_pte_unset(pt, &pvo->pvo_pte.lpte, pvo->pvo_vpn);
 			PVO_PTEGIDX_CLR(pvo);
 			moea64_pte_overflow++;
@@ -2827,9 +2827,9 @@ moea64_pte_insert(u_int ptegidx, struct 
 		/* It could have landed in the secondary PTEG */
 		pteg_bktidx ^= moea64_pteg_mask;
 		LIST_FOREACH(pvo, &moea64_pvo_table[pteg_bktidx], pvo_olink) {
-			if (!(pvo->pvo_pte.lpte.pte_hi & LPTE_VALID))
-				continue;
 			if (pvo->pvo_pte.lpte.pte_hi == pt->pte_hi) {
+				KASSERT(pvo->pvo_pte.lpte.pte_hi & LPTE_VALID, 
+				    ("Invalid PVO for valid PTE!\n"));
 				moea64_pte_unset(pt, &pvo->pvo_pte.lpte,
 				    pvo->pvo_vpn);
 				PVO_PTEGIDX_CLR(pvo);


More information about the svn-src-projects mailing list