svn commit: r365506 - in head: include lib/libc/gen lib/libc/sys

[Kyle Evans]

On Wed, Sep 9, 2020 at 1:07 PM Kyle Evans <kevans at freebsd.org> wrote:
>
> Author: kevans
> Date: Wed Sep  9 18:07:13 2020
> New Revision: 365506
> URL: https://svnweb.freebsd.org/changeset/base/365506
>
> Log:
>   getlogin_r: fix the type of len
>
>   getlogin_r is specified by POSIX to to take a size_t len, not int. Fix our
>   version to do the same, bump the symbol version due to ABI change and
>   provide compat.
>
>   This was reported to break compilation of Ruby 2.8.
>
>   Some discussion about the necessity of the ABI compat did take place in the
>   review. While many 64-bit platforms would likely be passing it in a 64-bit
>   register and zero-extended and thus, not notice ABI breakage, some do
>   sign-extend (e.g. mips).
>
>   PR:           247102
>   Submitted by: Bertram Scharpf <software at bertram-scharpf.de> (original)
>   Submitted by: cem (ABI compat)
>   MFC after:    1 week
>   Differential Revision:        https://reviews.freebsd.org/D26335
>

Argh, I dropped this =(:

Reviewed by: emaste, jhb, kib