svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph...

Warner Losh imp at bsdimp.com
Sat Sep 5 02:57:39 UTC 2020


On Fri, Sep 4, 2020, 7:05 PM Mark Linimon <linimon at lonesome.com> wrote:

> On Fri, Sep 04, 2020 at 02:15:04PM -0400, Andrew Gallatin wrote:
> > and I also anticipate it will cause problems with MFCs
>
> And existing PRs and DRs.
>

Or we could just not bother we these changes at all. It's a pipe dream we
will ever be style(9) compliant in all our code, or that we can magically
have a tool to enforce in new commits. We have better things to worry
about. We should continue to ignore this non problem and for new users
point them at the 95% correct format thing to run their submitted patches
if they submit something too far out of whack.

The last sweep deleted a boatload of blank lines that were in there on
purpose. Not worth adding them back, but still annoying to no real benefit.

I just don't see the benefits at all of doing anything here. The few
reviews that I've seen mention it seem to be the right level of effort.

Warner

>


More information about the svn-src-head mailing list