svn commit: r367695 - in head/sys: kern sys

[Ian Lepore]

On Wed, 2020-11-18 at 15:37 -0800, John Baldwin wrote:
> On 11/18/20 2:16 PM, Mateusz Guzik wrote:
> > On 11/17/20, John Baldwin <jhb at freebsd.org> wrote:
> > > On 11/14/20 11:22 AM, Mateusz Guzik wrote:
> > 
> > Interested parties can check the consumer (also seen in the diff)
> > to
> > see this is for consistency. I don't think any comments are
> > warranted
> > in the header.
> 
> I did read the consumer, and there didn't seem tremendous value in
> the
> extra line there.
> 
> > > These changes would benefit from review.
> > > 
> > 
> > I don't think it's feasible to ask for review for everything lest
> > it
> > degardes to rubber stamping and I don't think this change warranted
> > it, regardless of the cosmetic issues which can always show up.
> 
> That is not consistent with the direction the project is moving.  If
> you
> check the commit logs of other high-volume committers such as markj@,
> kib@, or myself, you will find that a substantial number of those
> commits
> are reviewed (typically in phabricator) without preventing us from
> making useful progress.  Also, while the previous core did not
> mandate
> reviews, we moved closer to it when the Pre-Commit Review chapter was
> added to the Committer's Guide:
> 
> 
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/pre-commit-review.html
> 
> In the related thread on developers@ we indicated that while weren't
> yet
> making pre-commit review mandatory, we collectively want to move in
> that
> direction.
> 

Yeah, the direction the project is moving is to drive away the few
remaining prolific contributors with policies that take all the
satisfaction out of working on freebsd.  There's a reason I've gone
from being in the top ten commiters list in 2019 to having around a
dozen commits in 2020.  (Harrison Bergeron lives, it seems, but the
world has so many more Diana Moon Glampers to counter with.)

-- Ian