svn commit: r367321 - head/sys/amd64/linux

[Mateusz Piotrowski]

Hi!

On 11/4/20 1:09 PM, Kristof Provost wrote:
> On 4 Nov 2020, at 11:45, Gordon Bergling wrote:
>> Shouldn't such a commit be approved by someone?
>>
> The committer’s guide seems clear that doc committers may fix comments:
>
> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/committer.types.html
>
>> doc committers may commit documentation changes to src files, such as man pages, READMEs, fortune 
>> databases, calendar files, and comment fixes without approval from a src committer, subject to 
>> the normal care and tending of commits.
>
> Arguably minor spelling fixes are not worth confusing the blame output for, but this seems well 
> within the established rules.

+1

BTW, I've another similar patch pending (this time for pmcstat) if some src committer could take a 
look: https://reviews.freebsd.org/D26082.


>
>> And why you just abandoned the differential [1]?
>>
> Probably because it timed out. The review had been pending since August.
> Arguably the differential link should have been included as well, but it’s hardly important in 
> this case. I don’t think we have explicit policies about this. We probably should.

I forgot to link to the review on Phabricator. I didn't follow up with an email as it didn't seem 
important enough to show up in everyone's mailbox.

Cheers!

Mateusz