svn commit: r359385 - head/usr.bin/kyua

Enji Cooper yaneurabeya at gmail.com
Sat Mar 28 02:02:37 UTC 2020


> On Mar 27, 2020, at 6:33 PM, Ed Maste <emaste at freebsd.org> wrote:
> 
> On Fri, 27 Mar 2020 at 21:09, Enji Cooper <ngie at freebsd.org> wrote:
>> 
>> Author: ngie
>> Date: Sat Mar 28 01:08:20 2020
>> New Revision: 359385
>> URL: https://svnweb.freebsd.org/changeset/base/359385
>> 
>> Log:
>>  Check in the generated copies of the manpages
> 
> I think this is the wrong change for the issue reported by Julian H
> Stacey, although I don't think having generated manpages committed to
> the tree matters too much in practice.
> 
>>  In the event that one's build environment doesn't define `$SH`, the build
>>  will also fail until this change is introduced.
> 
> This isn't the case - the reported failure occurred because the
> manbuild.sh script did not have +x set. My local builds and CI builds
> were fine, without having SH defined.


	I understand, but I’d rather not rely on a script’s mode, though. This is how build failures happen when the source tree is checked out somewhere with -o noexec.
Thanks,
-Enji


More information about the svn-src-head mailing list