svn commit: r358995 - head/sys/net

[Patrick Kelsey]

On Mon, Mar 16, 2020 at 7:55 AM Slawa Olhovchenkov <slw at zxy.spb.ru> wrote:

> On Sat, Mar 14, 2020 at 07:43:44PM +0000, Patrick Kelsey wrote:
>
> > Author: pkelsey
> > Date: Sat Mar 14 19:43:44 2020
> > New Revision: 358995
> > URL: https://svnweb.freebsd.org/changeset/base/358995
> >
> > Log:
> >   Fix iflib freelist state corruption
> >
> >   This fixes a bug in iflib freelist management that breaks the required
> >   correspondence between freelist indexes and driver ring slots.
> >
> >   PR:         243126, 243392, 240628
>
> Are you sure?
> Bug 240628 - sysutils/zfsnap2: Completion script link for zsh has
> wrong path
>
>
Unfortunately, that should be 240608, not 240628.


> >   Reported by:        avg, alexandr.oleynikov at gmail.com, Harald
> Schmalzbauer
> >   Reviewed by:        avg, gallatin
> >   MFC after:  1 week
> >   Differential Revision:      https://reviews.freebsd.org/D23943
>
> Very interesting.
> Is this related to my problem?
> I am have trouble w/ netmap:
>
> 1. netmap reported RX slots filled all ring (tail == head-1)
> 2. application processed all RX slots and reported to nemap (head == tail)
> 3. RX stuck.
>
> workaround: report on step 2 head = tail-1 (one RX slots left
> unprocessed).
>
> Also I am have trouble w/ TX, similar.
>

 This commit changes code that netmap does not use.  netmap freelist refill
is handled via netmap_fl_refill() in iflib.c, and that was not examined as
part of this work.

-Patrick