svn commit: r362361 - in head/sys: compat/linuxkpi/common/src vm

Mark Johnston markj at freebsd.org
Fri Jun 19 11:07:20 UTC 2020


On Fri, Jun 19, 2020 at 06:02:18PM +0800, Li-Wen Hsu wrote:
> On Fri, Jun 19, 2020 at 11:32 AM Mark Johnston <markj at freebsd.org> wrote:
> >
> > Author: markj
> > Date: Fri Jun 19 03:32:04 2020
> > New Revision: 362361
> > URL: https://svnweb.freebsd.org/changeset/base/362361
> >
> > Log:
> >   Add a helper function for validating VA ranges.
> >
> >   Functions which take untrusted user ranges must validate against the
> >   bounds of the map, and also check for wraparound.  Instead of having the
> >   same logic duplicated in a number of places, add a function to check.
> >
> >   Reviewed by:  dougm, kib
> >   Sponsored by: The FreeBSD Foundation
> >   MFC after:    1 week
> >   Differential Revision:        https://reviews.freebsd.org/D25328
> 
> I'm not sure if it's this one, or 3623630, the following i386 tests
> all panicked:

It was 3623630, which was totally wrong.

> https://ci.freebsd.org/job/FreeBSD-head-i386-test/9681/console
> 
> 00:11:31.669 lib/libc/net/protoent_test:protoent  ->  panic:
> __rw_wlock_hard: recursing but non-recursive rw vm object @
> /usr/src/sys/vm/vm_object.c:869
> 
> https://ci.freebsd.org/job/FreeBSD-head-i386-test/9682/console
> (includes the fix or r362363)
> 
> 00:27:53.864 bin/pkill/pkill-j_test:main  ->  Sleeping thread (tid
> 100115, pid 65628) owns a non-sleepable lock
> 
> https://ci.freebsd.org/job/FreeBSD-head-i386-test/9683/console
> 
> 00:02:26.917 bin/pkill/pkill-j_test:main  ->  Sleeping thread (tid
> 100152, pid 26582) owns a non-sleepable lock
> 
> Can you help check these?

I reverted the change.  Sorry for the breakage.


More information about the svn-src-head mailing list