svn commit: r362217 - head/stand/common

Pedro Giffuni pfg at FreeBSD.org
Tue Jun 16 17:12:49 UTC 2020


On 16/06/2020 12:01, Ian Lepore wrote:
> On Tue, 2020-06-16 at 07:05 +0000, Toomas Soome wrote:
>> Author: tsoome
>> Date: Tue Jun 16 07:05:03 2020
>> New Revision: 362217
>> URL: https://svnweb.freebsd.org/changeset/base/362217
>>
>> Log:
>>    loader: variable i is unused without MBR/GPT support built in
>>    
>>    Because i is only used as index in for loop, declare it in for
>> statement.
>>
> As much as I prefer doing it this way, style(9) doesn't allow for
> variable declarations inside a for() statement (or even inside a local
> block, which is just too 1980s for me, but it is still our standard).

Perhaps style(9) needs updating? I think KNF is mandatory for kernel 
code only, and is only suggested for userland.

Pedro.



More information about the svn-src-head mailing list