svn commit: r361723 - head/sys/compat/linuxkpi/common/include/linux

[Emmanuel Vadot]

On Tue, 02 Jun 2020 11:31:58 +0000
"Bjoern A. Zeeb" <bzeeb-lists at lists.zabbadoz.net> wrote:

> On 2 Jun 2020, at 10:36, Emmanuel Vadot wrote:
> 
> >  Hello Hans,
> >
> > On Tue, 2 Jun 2020 10:19:45 +0000 (UTC)
> > Hans Petter Selasky <hselasky at FreeBSD.org> wrote:
> >
> >> Author: hselasky
> >> Date: Tue Jun  2 10:19:45 2020
> >> New Revision: 361723
> >> URL: https://svnweb.freebsd.org/changeset/base/361723
> >>
> >> Log:
> >>   Implement struct_size() function macro in the LinuxKPI.
> >>
> >>   MFC after:	1 week
> >>   Sponsored by:	Mellanox Technologies
> >>
> >> Modified:
> >>   head/sys/compat/linuxkpi/common/include/linux/kernel.h
> >>
> >> Modified: head/sys/compat/linuxkpi/common/include/linux/kernel.h
> >> ==============================================================================
> >> --- head/sys/compat/linuxkpi/common/include/linux/kernel.h	Tue Jun  2 
> >> 09:45:43 2020	(r361722)
> >> +++ head/sys/compat/linuxkpi/common/include/linux/kernel.h	Tue Jun  2 
> >> 10:19:45 2020	(r361723)
> >> @@ -555,4 +555,10 @@ linux_ratelimited(linux_ratelimit_t *rl)
> >>  	return (ppsratecheck(&rl->lasttime, &rl->counter, 1));
> >>  }
> >>
> >> +#define	struct_size(ptr, field, num) ({ \
> >> +	const size_t __size = offsetof(__typeof(*(ptr)), field); \
> >> +	const size_t __max = (SIZE_MAX - __size) / sizeof((ptr)->field[0]); 
> >> \
> >> +	((num) > __max) ? SIZE_MAX : (__size + sizeof((ptr)->field[0]) * 
> >> (num)); \
> >> +})
> >> +
> >>  #endif	/* _LINUX_KERNEL_H_ */
> >
> >  Can you bump FreeBSD_version so I can fix
> > https://github.com/freebsd/drm-kmod/ and update the
> > graphics/drm-devel-kmod port please ?
> 
> I almost wonder if we want a ?linuxkkpi version? to check instead.
> If there?s a lot more ?work? on the linuxkpi we might not want to 
> bump __FreeBSD_version for every change which can conflict/affect 
> external code?
> 
> /bz
> 

 There is a LINUXKPI_VERSION but that's for Linux version compliance.
It's not easy to add a linuxkpi_version like freebsd_version because
you cannot check it in the port makefile. But that might help when
mfc'ing linuxkpi stuff.
 FreeBSD_version is cheap enough to bump.

-- 
Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>