svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

Gleb Smirnoff glebius at freebsd.org
Thu Jan 30 20:43:25 UTC 2020


On Thu, Jan 30, 2020 at 10:28:01AM +0000, Hans Petter Selasky wrote:
H> Author: hselasky
H> Date: Thu Jan 30 10:28:01 2020
H> New Revision: 357291
H> URL: https://svnweb.freebsd.org/changeset/base/357291
H> 
H> Log:
H>   Widen EPOCH(9) usage in PCI WLAN drivers.
H>   
H>   Make sure all occurrences of ieee80211_input_xxx() in sys/dev are
H>   covered by a network epoch section. Do not depend on the interrupt
H>   handler nor any taskqueues being in a network epoch section.
H>   
H>   This patch should unbreak the PCI WLAN drivers after r357004.
H>   
H>   Pointy hat:	glebius@
H>   Sponsored by:	Mellanox Technologies

Hey, I have reviewed all of them.

The following drivers were not broken, and your change does 100%
recursive epoch_enter:

bwi, ipw, iwi, iwm, iwn, ral, rtwn, wi, wpi

The following drivers use taskq and would be fixed by D23408:

bwn, malo, mwl, wtap

P.S. A funny note about wtap. You modified even a function that
is a dead code - wtap_rx_deliver(). Gives some clue on quality
of your sweep over all drivers.

-- 
Gleb Smirnoff


More information about the svn-src-head mailing list