svn commit: r356260 - head/sys/fs/msdosfs

Mateusz Guzik mjg at FreeBSD.org
Wed Jan 1 22:50:24 UTC 2020


Author: mjg
Date: Wed Jan  1 22:50:23 2020
New Revision: 356260
URL: https://svnweb.freebsd.org/changeset/base/356260

Log:
  msdos: vgone unconstructed vnode before vputing it
  
  Otherwise someone else may race to start using it. Race window
  was opened by r351748 ("vfs: implement usecount implying holdcnt").
  
  Noted by:	kib

Modified:
  head/sys/fs/msdosfs/msdosfs_denode.c

Modified: head/sys/fs/msdosfs/msdosfs_denode.c
==============================================================================
--- head/sys/fs/msdosfs/msdosfs_denode.c	Wed Jan  1 22:47:00 2020	(r356259)
+++ head/sys/fs/msdosfs/msdosfs_denode.c	Wed Jan  1 22:50:23 2020	(r356260)
@@ -230,7 +230,7 @@ deget(struct msdosfsmount *pmp, u_long dirclust, u_lon
 			 * Arrange for vput() to just forget about it.
 			 */
 			ldep->de_Name[0] = SLOT_DELETED;
-
+			vgone(nvp);
 			vput(nvp);
 			*depp = NULL;
 			return (error);


More information about the svn-src-head mailing list