svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm

[Ian Lepore]

On Wed, 2020-08-26 at 19:04 +0200, Mateusz Guzik wrote:
> On 8/26/20, Jung-uk Kim <jkim at freebsd.org> wrote:
> > Author: jkim
> > Date: Wed Aug 26 16:55:28 2020
> > New Revision: 364822
> > URL: https://svnweb.freebsd.org/changeset/base/364822
> > 
> > Log:
> >   Fix Clang version detection.
> > 
> >   We prepend "FreeBSD" to Clang version string.  This broke
> > compiler test
> > for
> >   AVX instruction support.
> > 
> 
> What about other software checking in similar fashion? imo the right
> fix is to stop mucking with the way clang reports itself
> 

Maybe it would be better to not modify the start of the string. 
Instead of 

FreeBSD clang version 9.0.1 (git at github.com:llvm/llvm-project.git
c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1)

maybe

clang version 9.0.1 for FreeBSD (git at github.com:llvm/llvm-project.git
c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1)

-- Ian