svn commit: r354151 - in head: contrib/netbsd-tests/lib/libexecinfo lib/libexecinfo/tests

[Conrad Meyer]

Author: cem
Date: Tue Oct 29 18:24:36 2019
New Revision: 354151
URL: https://svnweb.freebsd.org/changeset/base/354151

Log:
  libexecinfo test: Don't strip installed test
  
  It turns out that a test of backtrace symbol resolution and formatting
  requires symbols.  Another option mightt be building with -rdynamic instead,
  but this works for now.
  
  Re-enabled skipped CI test, as it should now pass.
  
  PR:		241562
  Submitted by:	lwhsu
  Reported by:	lwhsu
  X-MFC-With:	r354126, r354135, r354144

Modified:
  head/contrib/netbsd-tests/lib/libexecinfo/t_backtrace.c
  head/lib/libexecinfo/tests/Makefile

Modified: head/contrib/netbsd-tests/lib/libexecinfo/t_backtrace.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libexecinfo/t_backtrace.c	Tue Oct 29 18:06:00 2019	(r354150)
+++ head/contrib/netbsd-tests/lib/libexecinfo/t_backtrace.c	Tue Oct 29 18:24:36 2019	(r354151)
@@ -151,9 +151,6 @@ ATF_TC_HEAD(backtrace_fmt_basic, tc)
 
 ATF_TC_BODY(backtrace_fmt_basic, tc)
 {
-	if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
-		atf_tc_skip("https://bugs.freebsd.org/241562");
-
 	myfunc(12);
 
 	if (prevent_inline)

Modified: head/lib/libexecinfo/tests/Makefile
==============================================================================
--- head/lib/libexecinfo/tests/Makefile	Tue Oct 29 18:06:00 2019	(r354150)
+++ head/lib/libexecinfo/tests/Makefile	Tue Oct 29 18:24:36 2019	(r354151)
@@ -6,6 +6,12 @@ TESTSRC=	${SRCTOP}/contrib/netbsd-tests/lib/libexecinf
 
 .include <bsd.own.mk>
 
+# Perhaps not surprisingly, the backtrace symbol test needs symbols.  Leave
+# them in:
+STRIP=
+# It could probably be made to work without symbols by checking pointer values
+# instead, but part of the tested functionality is the symbol resolution logic,
+# so that doesn't seem useful.
 NETBSD_ATF_TESTS_C+=	backtrace_test
 
 LIBADD.backtrace_test+=	execinfo