svn commit: r354482 - head/sys/x86/x86

[Andriy Gapon]

On 08/11/2019 00:04, Colin Percival wrote:
> On 2019-11-07 13:34, Andriy Gapon wrote:
>> On 07/11/2019 23:19, Colin Percival wrote:
>>> On 2019-11-07 13:14, Andriy Gapon wrote:
>>>>   x86 stack_save_td_running() can work safely only if IPI_TRACE is a
>>>>   non-maskable interrupt.  But at the moment FreeBSD/Xen does not provide
>>>>   support for the NMI delivery mode.  So, mark the functionality as
>>>>   unsupported similarly to other platforms without NMI.
>>>> [...]
>>>> +#ifdef XENHVM
>>>
>>> I'm not sure this does what you intended.  XENHVM simply adds *support* for
>>> running under Xen/HVM, and it's part of the GENERIC kernel.
>>
>> Oh... I should not have rushed.
>> So, I should really check for a run-time Xen marker?
> 
> I'm guessing that you want
> 
> #include <sys/systm.h>
> 
> ...
> 
> 	if (vm_guest == VM_GUEST_XEN)
> 		return (EOPNOTSUPP);
> 

Colin, thank you again.
But it seems that adding NMI support to a type of guest which is FreeBSD turned
out to be much easier than I imagined.  In fact, Roger (royger@) has already
come up with a patch.  I will be testing it soon.

-- 
Andriy Gapon