svn commit: r348445 - head/sys/dev/ixl

Li-Wen Hsu lwhsu at FreeBSD.org
Thu May 30 20:42:38 UTC 2019


Author: lwhsu
Date: Thu May 30 20:42:36 2019
New Revision: 348445
URL: https://svnweb.freebsd.org/changeset/base/348445

Log:
  Add the missing braces to fix the code not guarded by the if clause and has
  misleading indentation.  This is found by gcc -Wmisleading-indentation
  
  Approved by:	erj
  MFC after:	3 days
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D20428

Modified:
  head/sys/dev/ixl/i40e_common.c

Modified: head/sys/dev/ixl/i40e_common.c
==============================================================================
--- head/sys/dev/ixl/i40e_common.c	Thu May 30 19:18:01 2019	(r348444)
+++ head/sys/dev/ixl/i40e_common.c	Thu May 30 20:42:36 2019	(r348445)
@@ -383,13 +383,14 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug
  **/
 bool i40e_check_asq_alive(struct i40e_hw *hw)
 {
-	if (hw->aq.asq.len)
+	if (hw->aq.asq.len) {
 		if (!i40e_is_vf(hw))
 			return !!(rd32(hw, hw->aq.asq.len) &
 				I40E_PF_ATQLEN_ATQENABLE_MASK);
-		if (i40e_is_vf(hw))
+		else
 			return !!(rd32(hw, hw->aq.asq.len) &
 				I40E_VF_ATQLEN1_ATQENABLE_MASK);
+	}
 	return FALSE;
 }
 


More information about the svn-src-head mailing list