svn commit: r347392 - head/sbin/ifconfig

[Kyle Evans]

On Thu, May 9, 2019 at 12:27 PM Enji Cooper (yaneurabeya)
<yaneurabeya at gmail.com> wrote:
>
>
> > On May 9, 2019, at 05:58, Kyle Evans <kevans at FreeBSD.org> wrote:
> >
> > Author: kevans
> > Date: Thu May  9 12:58:33 2019
> > New Revision: 347392
> > URL: https://svnweb.freebsd.org/changeset/base/347392
> >
> > Log:
> >  ifconfig(8): Partial revert of r347241
> >
> >  r347241 introduced an ifname <-> kld mapping table, mostly so tun/tap/vmnet
> >  can autoload the correct module on use. It also inadvertently made bogus
> >  some previously valid uses of sizeof().
> >
> >  Revert back to ifkind on the stack for simplicity sake. This reduces the
> >  diff from the previous version of ifmaybeload for easiser auditing.
>
> Hi Kyle,
>         Thank you for this revert. This change fixed the FreeBSD test suite runs, which are once again green after this change. A number of tests which use ifconfig were failing because they couldn’t configure interfaces: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/11134/testReport/ .
> Cheers!
> -Enji

Hi,

Sorry- I failed in the commit message. =(

Reported by: ci (via lwhsu)

lwhsu clued me in this morning. =)

Thanks!

Kyle Evans