svn commit: r346217 - in head/sys: fs/nfs fs/nfsclient kern sys

Rick Macklem rmacklem at uoguelph.ca
Fri May 3 14:49:54 UTC 2019


Harry Schmalzbauer wrote:
>Am 15.04.2019 um 03:27 schrieb Rick Macklem:
>> Author: rmacklem
>> Date: Mon Apr 15 01:27:15 2019
>> New Revision: 346217
>> URL: https://svnweb.freebsd.org/changeset/base/346217
>>
>> Log:
>>    Fix the NFSv4 client to safely find processes.
>>
>>    r340744 broke the NFSv4 client, because it replaced pfind_locked() with a
>>    call to pfind(), since pfind() acquires the sx lock for the pid hash and
>>    the NFSv4 already holds a mutex when it does the call.
>>    The patch fixes the problem by recreating a pfind_any_locked() and adding the
>>    functions pidhash_slockall() and pidhash_sunlockall to acquire/release
>>    all of the pid hash locks.
>>    These functions are then used by the NFSv4 client instead of acquiring
>>    the allproc_lock and calling pfind().
>>
>>    Reviewed by:       kib, mjg
>>    MFC after: 2 weeks
>
>Hello, I guess as long as r340744 isn't MFCd, this commit isn't needed
>in /stable/, is it?
That is correct. I hadn't looked to see if r340744 was MFC'd when I did the commit.

>Any plans to MFC
>https://svnweb.freebsd.org/base?view=revision&revision=340744
>(proc: convert pfind & friends to use pidhash locks and other cleanup)
No MFC is listed for the commit, so I am assuming that the author isn't planning
on MFC'ng it.

rick



More information about the svn-src-head mailing list