svn commit: r344099 - head/sys/net

Andrew Gallatin gallatin at cs.duke.edu
Fri Feb 22 16:50:33 UTC 2019


I think the misunderstanding here is that I think he's not getting the 
ifp from the route.

My recollection is that he is holding the ifps when he enables HW pacing 
in BBR.  Due to limitations in different NIC hardware, you can only have 
N different rates, etc.  So he goes ahead and allocates those N rates up 
front so that he knows he can reserve them & know that he can always get 
them.

Then when the system reboots, BBR has an eventhandler that goes ahead 
and frees those reservations.  I think that he's using the ifp that he's 
holding here.

In the case that tripped him up, that ifp was lagg.

Your workaround would also work, but Randall does have a point about 
symmetric alloc/free especially when viewed from his perspective,


Drew




More information about the svn-src-head mailing list