svn commit: r355600 - in head: share/man/man9 sys/kern sys/sys

John Baldwin jhb at FreeBSD.org
Tue Dec 10 22:47:39 UTC 2019


On 12/10/19 2:09 PM, Hans Petter Selasky wrote:
> On 2019-12-10 22:58, John Baldwin wrote:
>>   While here, add <sys/callout.h> to the manpage.
> 
> FYI:
> 
> Linux guys eliminated the "void *c_arg" in their timer implementation by 
> using container_of() to get callback argument. We could possibly do the 
> same!

You mean passing the pointer to the callout itself and using that to get to the
relevant pointer?  That seems less obvious from a code readability standpoint.
We also don't actually guarantee that the 'struct callout' is still alive when
the function is called currently (hence the need for the local variables that
store a copy of the fields).

-- 
John Baldwin


More information about the svn-src-head mailing list