svn commit: r339936 - head/sys/amd64/vmm/amd
Ian Lepore
ian at freebsd.org
Wed Oct 31 14:52:41 UTC 2018
On Wed, 2018-10-31 at 10:06 -0400, Shawn Webb wrote:
> On Wed, Oct 31, 2018 at 01:27:44AM +0000, Marcelo Araujo wrote:
> >
> > Author: araujo
> > Date: Wed Oct 31 01:27:44 2018
> > New Revision: 339936
> > URL: https://svnweb.freebsd.org/changeset/base/339936
> >
> > Log:
> > Merge cases with upper block.
> > This is a cosmetic change only to simplify code.
> >
> > Reported by: anish
> > Sponsored by: iXsystems Inc.
> >
> > Modified:
> > head/sys/amd64/vmm/amd/svm_msr.c
> >
> > Modified: head/sys/amd64/vmm/amd/svm_msr.c
> > ===================================================================
> > ===========
> > --- head/sys/amd64/vmm/amd/svm_msr.c Tue Oct 30 23:09:04
> > 2018 (r339935)
> > +++ head/sys/amd64/vmm/amd/svm_msr.c Wed Oct 31 01:27:44
> > 2018 (r339936)
> > @@ -122,11 +122,7 @@ svm_rdmsr(struct svm_softc *sc, int vcpu,
> > u_int num, u
> > case MSR_MTRR16kBase ... MSR_MTRR16kBase + 1:
> > case MSR_MTRR64kBase:
> > case MSR_SYSCFG:
> > - *result = 0;
> > - break;
> > case MSR_AMDK8_IPM:
> > - *result = 0;
> > - break;
> > case MSR_EXTFEATURES:
> > *result = 0;
> > break;
> Does this need a /* FALLTHROUGH */ comment to appease the Coverity
> Gods?
>
> Thanks,
>
I would hope not, stacking multiple case values together is a common
technique that almost never indicates a coding accident. The fall-
through warning should only get triggered when there is executable code
without a break between the various case values.
Good:
case 1:
case 2:
code();
break;
Warning:
case 1:
code();
case 2:
morecode();
break;
-- Ian
More information about the svn-src-head
mailing list