svn commit: r334238 - head/sys/kern

Eric van Gyzen vangyzen at FreeBSD.org
Sat May 26 14:01:45 UTC 2018


Author: vangyzen
Date: Sat May 26 14:01:44 2018
New Revision: 334238
URL: https://svnweb.freebsd.org/changeset/base/334238

Log:
  kdb_trap: Fix use of uninitialized data
  
  In some cases, other_cpus was used without being initialized.
  Thankfully, it was harmless.
  
  Reported by:	Coverity
  CID:		1385265
  Sponsored by:	Dell EMC

Modified:
  head/sys/kern/subr_kdb.c

Modified: head/sys/kern/subr_kdb.c
==============================================================================
--- head/sys/kern/subr_kdb.c	Sat May 26 11:13:17 2018	(r334237)
+++ head/sys/kern/subr_kdb.c	Sat May 26 14:01:44 2018	(r334238)
@@ -708,9 +708,10 @@ kdb_trap(int type, int code, struct trapframe *tf)
 	kdb_active--;
 
 #ifdef SMP
-	CPU_AND(&other_cpus, &stopped_cpus);
-	if (did_stop_cpus)
+	if (did_stop_cpus) {
+		CPU_AND(&other_cpus, &stopped_cpus);
 		restart_cpus(other_cpus);
+	}
 #endif
 
 	intr_restore(intr);


More information about the svn-src-head mailing list