svn commit: r333457 - head/sys/kern

[Andrew Gallatin]

On 05/10/18 07:36, Ed Maste wrote:
> Author: emaste
> Date: Thu May 10 11:36:16 2018
> New Revision: 333457
> URL: https://urldefense.proofpoint.com/v2/url?u=https-3A__svnweb.freebsd.org_changeset_base_333457&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Ed-falealxPeqc22ehgAUCLh8zlZbibZLSMWJeZro4A&m=Y7TkuLso5vnwZN5ypgs4eLKVEdMOSRgvhZZz1iAMdyU&s=-shrydFGkcYwmYlaG3W1nMyk2hg7rbKzCPfHI8_6GYM&e=
> 
> Log:
>    ANSIfy sys_generic.c
> 
> Modified:
>    head/sys/kern/sys_generic.c
> 
> Modified: head/sys/kern/sys_generic.c
> ==============================================================================
> --- head/sys/kern/sys_generic.c	Thu May 10 09:37:54 2018	(r333456)
> +++ head/sys/kern/sys_generic.c	Thu May 10 11:36:16 2018	(r333457)

<..>

> @@ -532,11 +519,7 @@ sys_pwritev(struct thread *td, struct pwritev_args *ua
>   }
>   
>   int
> -kern_pwritev(td, fd, auio, offset)
> -	struct thread *td;
> -	struct uio *auio;
> -	int fd;
> -	off_t offset;
> +kern_pwritev(struct thread *td, struct uio *auio, int fd, off_t offset)
>   {
>   	struct file *fp;
>   	int error;


This breaks the kernel build:

/usr/src/sys/kern/sys_generic.c:522:1: error: conflicting types for 
'kern_pwritev'
kern_pwritev(struct thread *td, struct uio *auio, int fd, off_t offset)
^
/usr/src/sys/sys/syscallsubr.h:212:5: note: previous declaration is here
int     kern_pwritev(struct thread *td, int fd, struct uio *auio, off_t 
offset);
         ^
1 error generated.
*** [sys_generic.o] Error code 1


I think the problem was that the non-ansi args were enumerated in a 
different order than their type declarations.

Drew