svn commit: r333373 - head/sys/net

[Stephen Hurd]

Author: shurd
Date: Tue May  8 17:15:10 2018
New Revision: 333373
URL: https://svnweb.freebsd.org/changeset/base/333373

Log:
  iflib: print message when iflib_tx_structures_setup fails
  
  Print a message when iflib_tx_structures_setup fails, like we do for
  iflib_rx_structures_setup.
  
  Now that we always print a message from within
  iflib_qset_structures_setup when it fails, stop printing one in
  iflib_device_register() at the call site.
  
  Submitted by:	Jacob Keller <jacob.e.keller at intel.com>
  Reviewed by:	gallatin
  MFC after:	3 days
  Sponsored by:	Intel Corporation
  Differential Revision:	https://reviews.freebsd.org/D15300

Modified:
  head/sys/net/iflib.c

Modified: head/sys/net/iflib.c
==============================================================================
--- head/sys/net/iflib.c	Tue May  8 17:14:54 2018	(r333372)
+++ head/sys/net/iflib.c	Tue May  8 17:15:10 2018	(r333373)
@@ -4398,10 +4398,8 @@ iflib_device_register(device_t dev, void *sc, if_share
 		goto fail;
 	}
 
-	if ((err = iflib_qset_structures_setup(ctx))) {
-		device_printf(dev, "qset structure setup failed %d\n", err);
+	if ((err = iflib_qset_structures_setup(ctx)))
 		goto fail_queues;
-	}
 
 	/*
 	 * Group taskqueues aren't properly set up until SMP is started,
@@ -5070,8 +5068,10 @@ iflib_qset_structures_setup(if_ctx_t ctx)
 	 * It is expected that the caller takes care of freeing queues if this
 	 * fails.
 	 */
-	if ((err = iflib_tx_structures_setup(ctx)) != 0)
+	if ((err = iflib_tx_structures_setup(ctx)) != 0) {
+		device_printf(ctx->ifc_dev, "iflib_tx_structures_setup failed: %d\n", err);
 		return (err);
+	}
 
 	if ((err = iflib_rx_structures_setup(ctx)) != 0)
 		device_printf(ctx->ifc_dev, "iflib_rx_structures_setup failed: %d\n", err);