svn commit: r331413 - head/sys/dev/efidev

Kyle Evans kevans at FreeBSD.org
Fri Mar 23 02:45:09 UTC 2018


Author: kevans
Date: Fri Mar 23 02:45:09 2018
New Revision: 331413
URL: https://svnweb.freebsd.org/changeset/base/331413

Log:
  efidev: Drop a quick note in about efi_cfgtbl/efi_runtime
  
  There's no real annotation for it, so it's not immediately obvious to the
  unfamiliar that these pointers are to locations in the EFI runtime map
  unlike the system table pointer immediately above them.

Modified:
  head/sys/dev/efidev/efirt.c

Modified: head/sys/dev/efidev/efirt.c
==============================================================================
--- head/sys/dev/efidev/efirt.c	Fri Mar 23 02:38:31 2018	(r331412)
+++ head/sys/dev/efidev/efirt.c	Fri Mar 23 02:45:09 2018	(r331413)
@@ -57,6 +57,11 @@ __FBSDID("$FreeBSD$");
 #include <vm/vm_map.h>
 
 static struct efi_systbl *efi_systbl;
+/*
+ * The following pointers point to tables in the EFI runtime service data pages.
+ * Care should be taken to make sure that we've properly entered the EFI runtime
+ * environment (efi_enter()) before dereferencing them.
+ */
 static struct efi_cfgtbl *efi_cfgtbl;
 static struct efi_rt *efi_runtime;
 


More information about the svn-src-head mailing list