svn commit: r330240 - in head/sys: conf powerpc/conf powerpc/powernv

[Nathan Whitehorn]

On 03/01/18 06:11, Wojciech Macek wrote:
> Author: wma
> Date: Thu Mar  1 14:11:07 2018
> New Revision: 330240
> URL: https://svnweb.freebsd.org/changeset/base/330240
>
> Log:
>    PowerNV: Initial support for OPAL I2C transfers
>    
>    Add I2C OPAL driver and a set of dummy-ones to allow
>    all I2C things on Power8 to attach.
>    
>    TODO: better async token management
>    
>    Submitted by:          Wojciech Macek <wma at semihalf.com>
>    Obtained from:         Semihalf
>    Sponsored by:          IBM, QCM Technologies
>
> Added:
>    head/sys/powerpc/powernv/opal_i2c.c   (contents, props changed)
>    head/sys/powerpc/powernv/opal_i2cm.c   (contents, props changed)
>    head/sys/powerpc/powernv/powernv_centaur.c   (contents, props changed)
>    head/sys/powerpc/powernv/powernv_xscom.c   (contents, props changed)
> Modified:
>    head/sys/conf/files.powerpc
>    head/sys/powerpc/conf/GENERIC64
>    head/sys/powerpc/powernv/opal.h
>
> Modified: head/sys/conf/files.powerpc
> ==============================================================================
> --- head/sys/conf/files.powerpc	Thu Mar  1 13:52:18 2018	(r330239)
> +++ head/sys/conf/files.powerpc	Thu Mar  1 14:11:07 2018	(r330240)
> @@ -186,9 +186,13 @@ powerpc/powermac/vcoregpio.c	optional	powermac
>   powerpc/powernv/opal.c		optional	powernv
>   powerpc/powernv/opal_console.c	optional	powernv
>   powerpc/powernv/opal_dev.c	optional	powernv
> +powerpc/powernv/opal_i2c.c	optional	iicbus fdt powernv
> +powerpc/powernv/opal_i2cm.c	optional	iicbus fdt powernv

These don't use FDT functions directly (and shouldn't), so you should 
remove the fdt part on the right. We only gate on 'options FDT' for 
things that are really FDT- (as opposed to OF-) specific.

>   powerpc/powernv/opal_pci.c	optional	powernv pci
>   powerpc/powernv/opalcall.S	optional	powernv
>   powerpc/powernv/platform_powernv.c optional	powernv
> +powerpc/powernv/powernv_centaur.c	optional	powernv
> +powerpc/powernv/powernv_xscom.c	optional	powernv
>   powerpc/powerpc/altivec.c	optional	powerpc | powerpc64
>   powerpc/powerpc/autoconf.c	standard
>   powerpc/powerpc/bcopy.c		standard
>
> Modified: head/sys/powerpc/conf/GENERIC64
> ==============================================================================
> --- head/sys/powerpc/conf/GENERIC64	Thu Mar  1 13:52:18 2018	(r330239)
> +++ head/sys/powerpc/conf/GENERIC64	Thu Mar  1 14:11:07 2018	(r330240)
> @@ -206,6 +206,7 @@ device		fwe		# Ethernet over FireWire (non-standard!)
>   
>   # Misc
>   device		iicbus		# I2C bus code
> +device		iic

Please add a comment here.
-Nathan