svn commit: r328430 - head/sbin/devd

[Warner Losh]

On Thu, Jan 25, 2018 at 10:02 PM, Matt Joras <matt.joras at gmail.com> wrote:

> On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh <imp at bsdimp.com> wrote:
> >
> >
> > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler <eadler at freebsd.org> wrote:
> >>
> >> Author: eadler
> >> Date: Fri Jan 26 04:40:41 2018
> >> New Revision: 328430
> >> URL: https://svnweb.freebsd.org/changeset/base/328430
> >>
> >> Log:
> >>   devd: minor nits
> >>
> >>   - mark usage as noreturn
> >>   - config does not need a virtual destructor
> >
> >
> > Everything needs a virtual destructor...  Please back that part of this
> > out...
> >
> > Warner
> Needs? If there's not inheritance there's no _need_ to do it, and it's
> arguably superfluous. That being said it's also an arguably
> superfluous change to remove it.
>

OK. Needs might not be the proper word. It's a stylistic thing in all the
C++ code I write. It keeps me from having to go back later and add it back
when it really does need it after subclasses are derived from it. It's an
important detail that often gets overlooked. The cost is minimal. And this
isn't one of the rare cases where it's harmful to have it.

Warner