svn commit: r328263 - head/lib/libregex

Kyle Evans kevans at freebsd.org
Mon Jan 22 18:43:38 UTC 2018


On Mon, Jan 22, 2018 at 12:40 PM, Kyle Evans <kevans at freebsd.org> wrote:
> Author: kevans
> Date: Mon Jan 22 18:40:19 2018
> New Revision: 328263
> URL: https://svnweb.freebsd.org/changeset/base/328263
>
> Log:
>   libregex: Add a symbol map
>
>   kib points out that trying to re-use symbol versioning from libc is dirty
>   and wrong. The implementation in libregex is incompatible by design with the
>   implementation in libc. Using the symbol versions from libc can and likely
>   will cause confusions for linkers and bring unexpected behavior for
>   consumers that unwillingly (transitively) link against libregex.
>
>   Reported by:  kib
>

Another thing I forgot to note here: libregex symbol versioning was
actually not happening prior to this commit due to failure to define
VERSION_DEF. This has also been corrected in this commit.


More information about the svn-src-head mailing list