svn commit: r327705 - head/stand/mips/beri/common

[Warner Losh]

On Tue, Jan 9, 2018 at 10:05 AM, John Baldwin <jhb at freebsd.org> wrote:

> On Monday, January 08, 2018 12:02:09 PM Warner Losh wrote:
> > This should have been a nop... libsa specifically creates 'safe' headers
> > for all the standard ones.
> >
> > Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h...
>
> Would you prefer it to use stdint.h and stdio.h rather than stand.h?


No. stand.h is fine. I just wondered why you hit issues at all with
stdio.h. inttypes.h isn't supported because we don't implement the extra
functions defined there over stdint.h, so it should have given an error
when included. I'm just surprised I didn't catch it in my universe.sh
script that I use to build all loaders though...

Warner


> > Warner
> >
> > On Mon, Jan 8, 2018 at 11:47 AM, John Baldwin <jhb at freebsd.org> wrote:
> >
> > > Author: jhb
> > > Date: Mon Jan  8 18:47:35 2018
> > > New Revision: 327705
> > > URL: https://svnweb.freebsd.org/changeset/base/327705
> > >
> > > Log:
> > >   Use <stand.h> instead of <inttypes.h> and <stdio.h> in boot code.
> > >
> > >   In the freestanding boot compile environment, standard headers are
> not
> > >   available.  Curiously, only building with clang exposed this as
> compiles
> > >   with external GCC still succeeded.
> > >
> > >   Sponsored by: DARPA / AFRL
> > >
> > > Modified:
> > >   head/stand/mips/beri/common/sdcard.c
> > >
> > > Modified: head/stand/mips/beri/common/sdcard.c
> > > ============================================================
> > > ==================
> > > --- head/stand/mips/beri/common/sdcard.c        Mon Jan  8 18:46:10
> 2018
> > >       (r327704)
> > > +++ head/stand/mips/beri/common/sdcard.c        Mon Jan  8 18:47:35
> 2018
> > >       (r327705)
> > > @@ -33,8 +33,7 @@
> > >  #include <sys/types.h>
> > >  #include <sys/endian.h>
> > >
> > > -#include <inttypes.h>
> > > -#include <stdio.h>
> > > +#include <stand.h>
> > >
> > >
> > >  /*
> > >
> > >
>
>
> --
> John Baldwin
>