svn commit: r329639 - head/sys/kern

Konstantin Belousov kostikbel at gmail.com
Tue Feb 20 11:42:53 UTC 2018


On Tue, Feb 20, 2018 at 10:58:33AM +0000, Bjoern A. Zeeb wrote:
> On 20 Feb 2018, at 10:52, Mateusz Guzik wrote:
> 
> > Author: mjg
> > Date: Tue Feb 20 10:52:07 2018
> > New Revision: 329639
> > URL: https://svnweb.freebsd.org/changeset/base/329639
> >
> > Log:
> >   Make killpg1 perform process validity checks without proc lock held.
> 
> I appreciate all these locking improvements!
> 
> I would feel a lot more easy about them if the commit message would also 
> detail why these changes are possible (e.g. only read-only variables 
> accessed, or variables only ever accessed thread local, ..) and not just 
> what the change is (which the diff also tells).
Removing PRS_NEW is certainly not safe.

> 
> Also, are there people reviewing all these changes?
> 


More information about the svn-src-head mailing list