svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2...

[Mark Johnston]

On Fri, Aug 17, 2018 at 09:17:58AM -0700, Conrad Meyer wrote:
> On Fri, Aug 17, 2018 at 9:12 AM, Warner Losh <imp at bsdimp.com> wrote:
> >
> > On Fri, Aug 17, 2018, 10:05 AM Conrad Meyer <cem at freebsd.org> wrote:
> >> We don't intend[sic] on tailoring it at all.
> >
> > We don't document such an exception... history tells me this belief may be
> > optimistic..
> 
> I think it is a generally understood convention re: contrib code.  I
> called out intent in the commit message for the directory, and anyway
> it is generally frowned upon in the project to modify contrib code for
> non-abandoned upstreams.  E.g., there was quite a bit of resistance
> modifying top(1) until it was deemed dead upstream and moved out of
> contrib.

Rather, I'd say it shouldn't be done gratuitously: every commit to
contrib code adds to our cumulative technical debt until it is
reconciled with upstream.  Sometimes, however, that's the right tradeoff
to make (or it's simply necessary for some reason).  In that case
having a vendor branch is important, and one should be created
preemptively even if there is no current intention to modify the
imported code.