svn commit: r326314 - in head/sys: ddb kern sys
Alexey Dokuchaev
danfe at FreeBSD.org
Wed Nov 29 06:57:02 UTC 2017
On Wed, Nov 29, 2017 at 04:04:49AM +1100, Bruce Evans wrote:
> On Tue, 28 Nov 2017, Edward Tomasz Napierala wrote:
> > Log:
> > Make kdb_reenter() silent when explicitly called from db_error().
> > This removes the useless backtrace on various ddb(4) user errors.
> >
> > Reviewed by: jhb@
> > Obtained from: CheriBSD
> > MFC after: 2 weeks
> > Sponsored by: DARPA, AFRL
> > Differential Revision: https://reviews.freebsd.org/D13212
>
> This doesn't fix the spam for user errors that cause a trap, which are
> very common (for mistyping memory addresses). ddb sets up trap handlers
> using setjmp, and actually does this correctly in many cases, but when
> a trap occurs the error handling is: [...]
>
> I use the following fix of disabling the spam in all cases (unless reenabled
> in all cases using ddb): [...]
Since someone is hacking on subr_kdb.c, may I ask them to commit attached
small patch? I want to do some work in that area, and these style issues
bug me.
./danfe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subr_kdb.c.diff
Type: text/x-diff
Size: 1095 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20171129/555c0569/attachment.diff>
More information about the svn-src-head
mailing list