svn commit: r317681 - head/share/man/man7

Konstantin Belousov kostikbel at gmail.com
Wed May 3 10:06:40 UTC 2017


On Wed, May 03, 2017 at 04:19:08PM +1000, Bruce Evans wrote:
> On Tue, 2 May 2017, Konstantin Belousov wrote:
> OK.
> 
> Including corrections by ngie:
> 
> > diff --git a/share/man/man7/arch.7 b/share/man/man7/arch.7
> > index 1ce397a303e..ad1abccc2e5 100644
> > --- a/share/man/man7/arch.7
> > +++ b/share/man/man7/arch.7
> > @@ -37,6 +37,8 @@ Differences between CPU architectures and platforms supported by
> > .Fx .
> > .Pp
> 
> This .Pp gives misformatting (an extra blank line) when followed by .Ss.
> Apparently, .Ss gives its own paragraph break.
> 
> > .Ss Type sizes
> > +If not explicitely mentioned, sizes are in bytes.
> 
> "explicitly"
> 
> This should be moved higher, so that it applies to the "Page Size" section.
> The first clause isn't needed, since there are no explicit mentions of
> sizes not in bytes (there is only "80 bits" for some FP values which don't
> claim to be sizes and aren't really sizes and should be changed to "64
> bits" and claim to be precisions).
> 
> > +.Pp
> 
> Check the formatting after moving the addition higher.  There will be 2
> very short paragraphs if you keep this .Pp.
Ok, see the cumulative changes in the patch.

> 
> > On all supported architectures,
> 
> The comma at the end of this should be a colon.
Ok.

> > +.Pp
> > +.Sy time_t
> > +is always signed, it is 64-bits everywere except on i386 and 32-bit powerpc.
> 
> Change "is always" to "On all supported arches" as elsewhere.
> 
> "everywhere"
> 
> "everywhere" is redundant.
Ok.

> 
> The whole second clause is redundant.  Remove it.  Leave it to the reader
> to notice that the table has more 8's than 4's, and where the 4's are.
No, this is one of the important reasons why this narrative text added
at all.

> This also fixes:
> - bad grammar (comma splice).  In general, use separate sentences, since
>    the rules for splicing clauses using commas and semicolons or avoiding
>    these using a word are complicated, though I used splicing in this
>    sentence to help make it so complicated (IIRC, "since" here is a
>    splicing method with some technical name like "conjunctive adjective").
> - inconsistent units (bytes in the table and bits here).
Ok.

diff --git a/share/man/man7/arch.7 b/share/man/man7/arch.7
index 47a72a1986d..62781430329 100644
--- a/share/man/man7/arch.7
+++ b/share/man/man7/arch.7
@@ -36,8 +36,9 @@
 Differences between CPU architectures and platforms supported by
 .Fx .
 .Pp
+If not explicitly mentioned, sizes are in bytes.
 .Ss Type sizes
-On all supported architectures,
+On all supported architectures:
 .Bl -column -offset -indent "long long" "Size"
 .It Sy Type Ta Sy Size
 .It short Ta 2
@@ -47,8 +48,10 @@ On all supported architectures,
 .It float Ta 4
 .It double Ta 8
 .El
-.Bl -column -offset indent "Sy Architecture" "Sy sizeof(void *)" "Sy sizeof(long double)" "Sy sizeof(time_t)"
-.It Sy Architecture Ta Sy sizeof(void *) Ta Sy sizeof(long double) Ta Sy sizeof(time_t)
+.Pp
+Machine-dependent type sizes:
+.Bl -column -offset indent "Sy Architecture" "Sy void *" "Sy long double" "Sy time_t"
+.It Sy Architecture Ta Sy void * Ta Sy long double Ta Sy time_t
 .It amd64       Ta 8 Ta 16 Ta 8
 .It arm         Ta 4 Ta  8 Ta 8
 .It armeb       Ta 4 Ta  8 Ta 8
@@ -70,6 +73,10 @@ On all supported architectures,
 .It riscv       Ta 8 Ta 16 Ta 8
 .It sparc64     Ta 8 Ta 16 Ta 8
 .El
+.Pp
+.Sy time_t
+is 8 bytes on all supported architectures except i386 and 32-bit
+variants of powerpc.
 .Ss Endianness and Char Signedness
 .Bl -column -offset indent "Sy Architecture" "Sy Endianness" "Sy char Signedness"
 .It Sy Architecture Ta Sy Endianness Ta Sy char Signedness


More information about the svn-src-head mailing list