svn commit: r316309 - head/sys/dev/qlxgbe

[Somayajulu, David]

Hi Hiren,
> I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled.
Will do. Sorry about that.

> Do you know of a case where one would want to disable h/w lro and enable s/w lro? I guess where you want to free up nic and make cpu do more work?
I was under the impression as well, that s/w lro is moot, if h/w lro was available, till one costumer asked for it. Not sure what the use case is.

Thanks
David S.

-----Original Message-----
From: hiren panchasara [mailto:hiren at strugglingcoder.info] 
Sent: Thursday, March 30, 2017 4:02 PM
To: David C Somayajulu <davidcs at FreeBSD.org>
Cc: src-committers at freebsd.org; svn-src-all at freebsd.org; svn-src-head at freebsd.org
Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe

On 03/30/17 at 10:43P, David C Somayajulu wrote:
> Author: davidcs
> Date: Thu Mar 30 22:43:32 2017
> New Revision: 316309
> URL: https://svnweb.freebsd.org/changeset/base/316309
> 
> Log:
>   Add support for optional Soft LRO

Hi David,

I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled.

Do you know of a case where one would want to disable h/w lro and enable s/w lro? I guess where you want to free up nic and make cpu do more work?

Cheers,
Hiren