svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Ngie Cooper (yaneurabeya)]

> On Mar 6, 2017, at 21:50, Rodney W. Grimes <freebsd at pdx.rh.CN85.dnsmgr.net> wrote:
> 
>>> On Mar 6, 2017, at 21:10, Rodney W. Grimes <rgrimes at FreeBSD.org> wrote:
>>> 
>>> Author: rgrimes
>>> Date: Tue Mar  7 05:10:38 2017
>>> New Revision: 314833
>>> URL: https://svnweb.freebsd.org/changeset/base/314833
> ...
> 
>>> 
>>> -SYMLINKS+=	${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
>>> +SYMLINKS+=	../../../tests/lib/libxo/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
>> 
>> 	This change breaks setting TESTSBASE != /usr/tests . Please fix (my employer depends on this being functional).
>> Thanks,
> 
> I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS and
> probably a much better fix in bsd.*.mk can be implemented.  I can live with
> one last nasty wart of an absolute link in DESTDIR until then.  The important
> functional ones are gone now.
> 
> To fix this without changing SYMLINKS would involve adding a local install:
> target which would be more mess than having the one absolute link.

The proposed enhancement for bsd.links.mk for RSYMLINKS can be found here: https://reviews.freebsd.org/D9919 .
Thanks,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170307/8c16fbcf/attachment.sig>