svn commit: r320156 - in head: cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzfs/common sys/cddl/contrib/opensolaris/common/zfs sys/cddl/contri...

[Andriy Gapon]

On 23/06/2017 06:10, Justin Hibbits wrote:
> This commit breaks gcc builds with new warnings introduced:
> 
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c: In function 'arc_kmem_reap_now':
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c:4364: warning: nested extern declaration of 'abd_chunk_cache' [-Wnested-externs]
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c: In function 'vdev_label_write_pad2': 
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c:902:
> warning: passing argument 2 of 'abd_copy_from_buf' discards qualifiers from
> pointer target type 

I missed the first one during the merge.
The second one is in FreeBSD specific code, but the root cause is that the
interface introduced upstream takes a non-const parameter where it should really
take a const one.

Thank you for the report.  I'll handle this.

-- 
Andriy Gapon