svn commit: r319295 - head/usr.bin/mkimg/tests

[Ngie Cooper (yaneurabeya)]

> On May 31, 2017, at 10:03 PM, Brooks Davis <brooks at FreeBSD.org> wrote:
> 
> On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote:
>> Author: ngie
>> Date: Wed May 31 08:01:12 2017
>> New Revision: 319295
>> URL: https://svnweb.freebsd.org/changeset/base/319295
>> 
>> Log:
>>  Update the usr.bin/mkimg golden test output files after ^/head at r319125
>> 
>>  ^/head at r319125 changed the location of the backup pmbr, requiring the
>>  output files to be regenerated, since they're binary disk dumps.
>> 
>>  The output files were regenerated with "make rebase"--fixed in
>>  ^/head at r319294.
> 
> These should not be stored uuencoded.  It serves no purpose other
> than bloating the repo and causing spammy commit mails like this one
> where we got a huge tail of garbage output.

Hi Brooks,
	I’m not entirely sure why the files were uuencoded to be honest. I think that’s a good question for Marcel and some of the folks at Juniper, since they wrote the tool/tests.
Thanks!
-Ngie

PS I agree based on what little I know, but I don’t necessarily know what trade offs were made with writing these tests.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170531/389ade55/attachment.sig>