svn commit: r321633 - in head/sys/arm: arm include

[Zbigniew Bodek]

2017-07-29 18:06 GMT+02:00 Ian Lepore <ian at freebsd.org>:
> On Thu, 2017-07-27 at 23:14 +0000, Zbigniew Bodek wrote:
>> Author: zbb
>> Date: Thu Jul 27 23:14:17 2017
>> New Revision: 321633
>> URL: https://svnweb.freebsd.org/changeset/base/321633
>>
>> Log:
>>   Fix TEX index acquisition using L2 attributes
>>
>>   The TEX index is selected using (TEX0 C B) bits
>>   from the L2 descriptor. Use correct index by masking
>>   and shifting those bits accordingly.
>>
>>   Differential Revision:      https://reviews.freebsd.org/D11703
>
> How did you guys discover this bug, like what were the symptoms?

Hello Ian,

We had bug in usage of  pmap_remap_vm_attr() and fixing it didn't help
for the issue so the second bug has been found here.

>  Should we consider merging this to 11-stable?

As far as I know nobody besides Armada38x is using this function in
HEAD and nobody uses it in 11.
You may merge it to 11 though (just for the safety of this code in the future).

>
> -- Ian