svn commit: r320842 - head/sys/fs/ext2fs

Pedro F. Giffuni pfg at FreeBSD.org
Sun Jul 9 15:19:29 UTC 2017


Author: pfg
Date: Sun Jul  9 15:19:28 2017
New Revision: 320842
URL: https://svnweb.freebsd.org/changeset/base/320842

Log:
  Remove stale comments.
  
  There's no real advantage in using memcpy here.
  
  Dicussed with:	bde (long ago)

Modified:
  head/sys/fs/ext2fs/ext2_inode_cnv.c

Modified: head/sys/fs/ext2fs/ext2_inode_cnv.c
==============================================================================
--- head/sys/fs/ext2fs/ext2_inode_cnv.c	Sun Jul  9 15:14:22 2017	(r320841)
+++ head/sys/fs/ext2fs/ext2_inode_cnv.c	Sun Jul  9 15:19:28 2017	(r320842)
@@ -126,7 +126,7 @@ ext2_ei2i(struct ext2fs_dinode *ei, struct inode *ip)
 	ip->i_gid = ei->e2di_gid;
 	ip->i_uid |= (uint32_t)ei->e2di_uid_high << 16;
 	ip->i_gid |= (uint32_t)ei->e2di_gid_high << 16;
-	/* XXX use memcpy */
+
 	for (i = 0; i < EXT2_NDADDR; i++)
 		ip->i_db[i] = ei->e2di_blocks[i];
 	for (i = 0; i < EXT2_NIADDR; i++)
@@ -176,7 +176,7 @@ ext2_i2ei(struct inode *ip, struct ext2fs_dinode *ei)
 	ei->e2di_uid_high = ip->i_uid >> 16 & 0xffff;
 	ei->e2di_gid = ip->i_gid & 0xffff;
 	ei->e2di_gid_high = ip->i_gid >> 16 & 0xffff;
-	/* XXX use memcpy */
+
 	for (i = 0; i < EXT2_NDADDR; i++)
 		ei->e2di_blocks[i] = ip->i_db[i];
 	for (i = 0; i < EXT2_NIADDR; i++)


More information about the svn-src-head mailing list