svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/...

[Bryan Drewery]

On 12/6/2017 4:28 PM, Hans Petter Selasky wrote:
> On 12/07/17 01:10, Bryan Drewery wrote:
>> I'm a bit speechless.  Why??  The old version was 90% fine and I sent
>> you advice on how to make it work with the new layout.
> 
> Hi,
> 
> I tried to listen to your advice, splitting up the Makefiles, not
> listing every dependency. Further how the OFED libraries are linked has
> changed. Two iterations for building the OFED libraries is not enough,
> like before. We really need four iterations.
> 
> I don't see how the current approach is "wrong". Can you explain a bit
> more?

1. SUBDIR=../../somewhere else is inherently wrong.
2. Building a library from a directory named '2' is wrong.
3. Not just using proper SUBDIR_DEPEND and making all these subdirs is
not needed and complicates things MORE by splitting them all up.
4. Building a library from a directory where its real bsd.lib.mk is not
at is wrong.
5. Depending on an include directory in the Makefile.inc1 library
dependencies is simply not needed - I told you that.
6. Using these /0 /1 /2 /3 directories actually hurts the 'make
libraries' parallelism/dependency graph. It ends up building /1 rather
than building libibcm and libibumad directly in its graph.  It creates
an indirection which adds more unneeded submake recursion.

The whole thing needlessly obfuscates these libraries.

It's fine, I'm going to rewrite it all now.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20171206/dfdab8d7/attachment.sig>