svn commit: r306512 - in head/sys: kern sys

Bryan Drewery bdrewery at FreeBSD.org
Fri Aug 25 23:18:24 UTC 2017


On 8/25/2017 3:37 PM, Konstantin Belousov wrote:
> On Fri, Aug 25, 2017 at 02:29:28PM -0700, Bryan Drewery wrote:
>> https://people.freebsd.org/~bdrewery/patches/vdrop-global-list.diff
> I do not object against his handling.
> 
> There is really very small amount of code shared between mp != NULL
> and mp == NULL cases, you may consider making them use separate paths
> instead of adding more than one check for mp != NULL.
> 

Sure, and I incorrectly was adding VMP_TMPMNTFREELIST flag for mp==NULL
case.  I'll open a review.

> VNASSERT() statement has wrong indent on the continuation line.
> 


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170825/de202456/attachment.sig>


More information about the svn-src-head mailing list