svn commit: r304510 - head/sys/dev/ixl

[Eric Joyner]

It's weird that the gcc message is mentioning "ixlv_media_change", but I'll
do something about it shortly.

On Wed, Aug 31, 2016 at 2:16 PM Dimitry Andric <dim at freebsd.org> wrote:

> On 31 Aug 2016, at 18:53, Ed Maste <emaste at freebsd.org> wrote:
> >
> > On 19 August 2016 at 20:08, Eric Joyner <erj at freebsd.org> wrote:
> >> Author: erj
> >> Date: Sat Aug 20 00:08:10 2016
> >> New Revision: 304510
> >> URL: https://svnweb.freebsd.org/changeset/base/304510
> >>
> >> Log:
> >>  ixlv(4): Fix ixlv(4) not loading when loaded as a kernel module and
> netmap is enabled.
> >
> > I did not confirm it's this commit, but kernel builds currently have
> > this warning:
> >
> > if_ixlv.o: warning: common of `ixl_crcstrip' overridden by definition
> > if_ixl.o: warning: defined here
> > if_ixlv.o: warning: multiple common of `ixl_rx_miss'
> > if_ixl.o: warning: previous common is here
> > if_ixlv.o: warning: multiple common of `ixl_rx_miss_bufs'
> > if_ixl.o: warning: previous common is here
>
> Interestingly, with the external gcc build, it is even an error:
>
> --- kernel.full ---
> linking kernel.full
> if_ixlv.o:(.bss+0x0): multiple definition of `ixl_crcstrip'
> if_ixl.o:(.data+0xb8): first defined here
> if_ixlv.o: In function `ixlv_media_change':
> /builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixlv.c:2252: multiple
> definition of `ixl_rx_miss_bufs'
> if_ixl.o:/builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixl.c:680: first
> defined here
> if_ixlv.o: In function `ixlv_media_change':
> /builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixlv.c:2262: multiple
> definition of `ixl_rx_miss'
> if_ixl.o:/builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixl.c:681: first
> defined here
> *** [kernel.full] Error code 1
>
> See e.g.
> https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc/1505/console
>
> -Dimitry
>
>