svn commit: r307911 - head/sys/boot/efi/loader

Warner Losh imp at FreeBSD.org
Tue Oct 25 14:42:10 UTC 2016


Author: imp
Date: Tue Oct 25 14:42:09 2016
New Revision: 307911
URL: https://svnweb.freebsd.org/changeset/base/307911

Log:
  Add better comment...

Modified:
  head/sys/boot/efi/loader/main.c

Modified: head/sys/boot/efi/loader/main.c
==============================================================================
--- head/sys/boot/efi/loader/main.c	Tue Oct 25 14:18:27 2016	(r307910)
+++ head/sys/boot/efi/loader/main.c	Tue Oct 25 14:42:09 2016	(r307911)
@@ -56,7 +56,17 @@ extern char bootprog_date[];
 extern char bootprog_maker[];
 
 #ifdef BOOT_FORTH
-/* Force a reference to bring in EFI support from the library */
+/*
+ * Normally, efi.o from libefi.a would be brought in due to a function we call
+ * there that's defined there.  However, none of its functions are callable from
+ * here since it just adds words to the FORTH environment or implement those
+ * words. So, add a reference to a symbol in efi.o to force it to be be brought
+ * in so the init function there gets added to the "compile" linker set happens
+ * correctly.
+ *
+ * This assumes there's no global analysys that notices dummy1 isn't used
+ * anywhere and tries to eliminate it.
+ */
 extern int efi_variable_support;
 int *dummy1 = &efi_variable_support;
 #endif


More information about the svn-src-head mailing list