svn commit: r307317 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

[Andriy Gapon]

On 14/10/2016 15:22, Alexander Motin wrote:
> On 14.10.2016 15:11, Andriy Gapon wrote:
>> On 14/10/2016 15:01, Alexander Motin wrote:
>>> Author: mav
>>> Date: Fri Oct 14 12:01:33 2016
>>> New Revision: 307317
>>> URL: https://svnweb.freebsd.org/changeset/base/307317
>>>
>>> Log:
>>>   MFV r307313:
>>>   5120 zfs should allow large block/gzip/raidz boot pool (loader project)
>>>   
>>>   Reviewed by: George Wilson <george.wilson at delphix.com>
>>>   Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
>>>   Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
>>>   Reviewed by: Matthew Ahrens <mahrens at delphix.com>
>>>   Approved by: Robert Mustacchi <rm at joyent.com>
>>>   Author: Toomas Soome <tsoome at me.com>
>>>   
>>>   openzfs/openzfs at c8811bd3e2427dddbac6c05a59cfe117d8fea370
>>>   
>>>   FreeBSD still does not support booting from gzip-compressed datasets,
>>>   so keep one chunk of this commit out.
>>
>> Does FreeBSD boot code support large blocks? Just to be sure.
> 
> According to r304321 commit message -- it does now.

Okay.

>> And maybe this is worth some additional notice because users sometimes forget to
>> upgrade gptzfsboot / zfsboot.
> 
> Where would you like to see it to be noticeable?

That's a good question for which I do not have a good answer.
Ideally 'zfs set recordsize=' would warn when setting a large block size on a
boot filesystem and 'zpool set bootfs=' would warn when switching the boot
filesystem to a filesystem that already has a large block size.
But not sure if that's doable without kludges.

-- 
Andriy Gapon