svn commit: r309109 - head/lib/libutil

John Baldwin jhb at freebsd.org
Thu Nov 24 19:11:28 UTC 2016


On Thursday, November 24, 2016 05:27:17 PM Dag-Erling Smørgrav wrote:
> Marcelo Araujo <araujobsdport at gmail.com> writes:
> > We have code review, we have some many ways for communication, even
> > revert a commit if needed.
> 
> No.  This is the kind of mistake where the code will seem to work just
> fine and end up in a release before a user suddenly discovers that they
> have two instances of the same daemon running and trashing their data.
> If I remember correctly, the last time someone touched flopen(),
> everything worked except 'service mountd reload' stopped working.

Of course, there's only one person who has touched flopen:

% svn log -q flopen.c | awk -F \| '/^r/ { print $2 }' | sort | uniq -c
  12  des 

Perhaps you were just warning yourself? :)

-- 
John Baldwin


More information about the svn-src-head mailing list